Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Julian as a contractor. #855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add @Julian as a contractor. #855

wants to merge 1 commit into from

Conversation

Julian
Copy link
Member

@Julian Julian commented Jan 12, 2025

Adds me :) hopefully I've done this right.

(A minor schema note is maybe we want incorporated to not be required, and to default to empty, but as it currently seems to be, I've included [].)

Refs: https://github.com/orgs/json-schema-org/discussions/779

@jviotti
Copy link
Member

jviotti commented Jan 13, 2025

A minor schema note is maybe we want incorporated to not be required

Isn't incorporation (at last as a sole proprietorship) required to do any sort of consulting in most parts of the world?

@Julian
Copy link
Member Author

Julian commented Jan 13, 2025

A sole proprietorship, at least in the US, is unincorporated!

@jviotti
Copy link
Member

jviotti commented Jan 13, 2025

Ah, interesting. Feel free to tweak the schema. I guess an empty array is also OK

@Julian
Copy link
Member Author

Julian commented Jan 13, 2025

Was the intention really incorporation? Or was it meant to be a field indicating where someone does business or something, regardless of what commercial entity? If the latter maybe it really is intended not to be empty?

@jviotti
Copy link
Member

jviotti commented Jan 13, 2025

Or was it meant to be a field indicating where someone does business or something

It was that. Essentially from which country are you legally doing business from, which might not necessarily be your country of origin or residence.

@Julian
Copy link
Member Author

Julian commented Jan 13, 2025

Aha! Then maybe another solution is renaming it to doingBusinessIn or something and then I'd put US. Maybe we can tweak it after this PR or if someone else has an opinion.

@jviotti
Copy link
Member

jviotti commented Jan 13, 2025

That works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants